♻️ Duplicate convos in DB when they are shared (#44)

src/lib/server/database.ts

@@ -1,6 +1,7 @@
 import { MONGODB_URL, MONGODB_DB_NAME } from '$env/static/private';
 import { MongoClient } from 'mongodb';
 import type { Conversation } from '$lib/types/Conversation';
+import type { SharedConversation } from '$lib/types/SharedConversation';
 
 const client = new MongoClient(MONGODB_URL, {
 	// directConnection: true
@@ -11,11 +12,12 @@ export const connectPromise = client.connect().catch(console.error);
 const db = client.db(MONGODB_DB_NAME);
 
 const conversations = db.collection<Conversation>('conversations');
+const sharedConversations = db.collection<SharedConversation>('sharedConversations');
 
 export { client, db };
-export const collections = { conversations };
+export const collections = { conversations, sharedConversations };
 
 client.on('open', () => {
 	conversations.createIndex({ sessionId: 1, updatedAt: -1 });
-	conversations.createIndex({ 'shares.id': 1 }, { unique: true, sparse: true });
+	sharedConversations.createIndex({ hash: 1 }, { unique: true });
 });

src/lib/types/Conversation.ts

@@ -5,13 +5,11 @@ export interface Conversation {
 	_id: ObjectId;
 
 	// Can be undefined for shared convo then deleted
-	sessionId?: string;
+	sessionId: string;
 
 	title: string;
 	messages: Message[];
 
-	shares?: Array<{ id: string; msgCount: number }>;
-
 	createdAt: Date;
 	updatedAt: Date;
 }

src/lib/types/SharedConversation.ts

@@ -0,0 +1,13 @@
+import type { Message } from './Message';
+
+export interface SharedConversation {
+	_id: string;
+
+	hash: string;
+
+	title: string;
+	messages: Message[];
+
+	createdAt: Date;
+	updatedAt: Date;
+}

src/lib/utils/sha256.ts

@@ -0,0 +1,7 @@
+export async function sha256(input: string): Promise<string> {
+	const utf8 = new TextEncoder().encode(input);
+	const hashBuffer = await crypto.subtle.digest('SHA-256', utf8);
+	const hashArray = Array.from(new Uint8Array(hashBuffer));
+	const hashHex = hashArray.map((bytes) => bytes.toString(16).padStart(2, '0')).join('');
+	return hashHex;
+}

src/routes/conversation/[id]/share/+server.ts

@@ -1,4 +1,6 @@
 import { collections } from '$lib/server/database.js';
+import type { SharedConversation } from '$lib/types/SharedConversation.js';
+import { sha256 } from '$lib/utils/sha256.js';
 import { error } from '@sveltejs/kit';
 import { ObjectId } from 'mongodb';
 import { nanoid } from 'nanoid';
@@ -13,39 +15,33 @@ export async function POST({ params, url, locals }) {
 		throw error(404, 'Conversation not found');
 	}
 
-	const shares = conversation.shares || [];
+	const hash = await sha256(JSON.stringify(conversation.messages));
 
-	const existingShare = shares.find((share) => share.msgCount === conversation.messages.length);
+	const existingShare = await collections.sharedConversations.findOne({ hash });
 
 	if (existingShare) {
 		return new Response(
 			JSON.stringify({
-				url: url.origin + `/r/${existingShare.id}`
+				url: url.origin + `/r/${existingShare._id}`
 			}),
 			{ headers: { 'Content-Type': 'application/json' } }
 		);
 	}
 
-	const share = {
-		id: nanoid(7),
-		msgCount: conversation.messages.length
+	const shared: SharedConversation = {
+		_id: nanoid(7),
+		createdAt: new Date(),
+		messages: conversation.messages,
+		hash,
+		updatedAt: new Date(),
+		title: conversation.title
 	};
 
-	await collections.conversations.updateOne(
-		{
-			_id: conversation._id
-		},
-		{
-			$set: {
-				shares: [...shares, share],
-				updatedAt: new Date()
-			}
-		}
-	);
+	await collections.sharedConversations.insertOne(shared);
 
 	return new Response(
 		JSON.stringify({
-			url: url.origin.replace('huggingface.co', 'hf.co') + `/r/${share.id}`
+			url: url.origin.replace('huggingface.co', 'hf.co') + `/r/${shared._id}`
 		}),
 		{ headers: { 'Content-Type': 'application/json' } }
 	);

src/routes/r/[id]/+page.server.ts

@@ -1,9 +1,10 @@
-import { collections } from '$lib/server/database.js';
+import type { PageServerLoad } from './$types';
+import { collections } from '$lib/server/database';
 import { error } from '@sveltejs/kit';
 
-export async function load({ params }) {
-	const conversation = await collections.conversations.findOne({
-		'shares.id': params.id
+export const load: PageServerLoad = async ({ params }) => {
+	const conversation = await collections.sharedConversations.findOne({
+		_id: params.id
 	});
 
 	if (!conversation) {
@@ -13,4 +14,4 @@ export async function load({ params }) {
 	return {
 		messages: conversation.messages
 	};
-}
+};